[U-Boot] [PATCH v3] sandbox: fix compiler warning
Albert ARIBAUD
albert.u.boot at aribaud.net
Wed Jan 23 07:46:03 CET 2013
Hi Allen,
On Tue, 22 Jan 2013 15:11:21 -0800, Allen Martin <amartin at nvidia.com>
wrote:
> Add back return statement to fix compiler warning about control flow
> reaching end of non void function that was introduced with:
>
> e05e5de arm: move C runtime setup code in crt0.S
>
> Signed-off-by: Allen Martin <amartin at nvidia.com>
> Acked-by: Simon Glass <sjg at chromium.org>
> ---
> arch/sandbox/cpu/start.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c
> index 7603bf9..5287fd5 100644
> --- a/arch/sandbox/cpu/start.c
> +++ b/arch/sandbox/cpu/start.c
> @@ -122,4 +122,7 @@ int main(int argc, char *argv[])
> * never return.
> */
> board_init_f(0);
> +
> + /* NOTREACHED - board_init_f() does not return */
> + return 0;
> }
Shouldn't the function be given '__attribute__((noreturn))' rather than
adding a non-executed 'return 0' to it?
Amicalement,
--
Albert.
More information about the U-Boot
mailing list