[U-Boot] [PATCH v5 1/2] mx23_olinuxino: Add default environment

[Marek Vasut]

Dear Otavio Salvador,

> On Wed, Jan 23, 2013 at 5:12 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Otavio Salvador,
> > 
> >> This adds a default environment with support for MMC booting.
> >> 
> >> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> >> ---
> >> Changes in v5:
> >> - Remove duplicate environment setting
> >> - Improve commit log
> >> 
> >> Changes in v4: None
> >> Changes in v3: None
> >> Changes in v2: None
> >> 
> >>  include/configs/mx23_olinuxino.h | 74
> >> 
> >> ++++++++++++++++++++++++++++++++++++---- 1 file changed, 67
> >> insertions(+), 7 deletions(-)
> >> 
> >> diff --git a/include/configs/mx23_olinuxino.h
> >> b/include/configs/mx23_olinuxino.h index bc63481..fc859b3 100644
> >> --- a/include/configs/mx23_olinuxino.h
> >> +++ b/include/configs/mx23_olinuxino.h
> >> @@ -114,6 +114,14 @@
> >> 
> >>  /*
> >>  
> >>   * MMC Driver
> >>   */
> >> 
> >> +#define      CONFIG_ENV_IS_IN_MMC
> >> +#define      CONFIG_ENV_OVERWRITE
> >> +#ifdef       CONFIG_ENV_IS_IN_MMC
> >> +#define      CONFIG_ENV_OFFSET       (256 * 1024)
> >> +#define      CONFIG_ENV_SIZE (16 * 1024)
> >> +#define      CONFIG_SYS_MMC_ENV_DEV 0
> >> +#endif
> > 
> > The stuff aboce goes into ENV section below
> > 
> >> +#define      CONFIG_CMD_SAVEENV
> > 
> > CMD goes under CMD section (is this really even needed? saveenv is there
> > all the time anyway)
> 
> Indeed this is not need; I removed it.
> 
> >>  #ifdef       CONFIG_CMD_MMC
> >>  #define      CONFIG_MMC
> >>  #define      CONFIG_BOUNCE_BUFFER
> >> 
> >> @@ -127,21 +135,73 @@
> >> 
> >>  #define CONFIG_APBH_DMA
> >>  
> >>  /*
> >> 
> >> - * ENV -- nowhere so far
> >> - */
> >> -#define      CONFIG_ENV_SIZE                 (16 * 1024)
> >> -#define      CONFIG_ENV_IS_NOWHERE
> >> -
> >> -/*
> >> 
> >>   * Boot Linux
> >>   */
> >>  
> >>  #define      CONFIG_CMDLINE_TAG
> >>  #define      CONFIG_SETUP_MEMORY_TAGS
> >>  #define      CONFIG_BOOTDELAY        3
> >>  #define      CONFIG_BOOTFILE         "uImage"
> >> 
> >> -#define      CONFIG_BOOTARGS         "console=ttyAMA0,115200n8 "
> >> 
> >>  #define      CONFIG_LOADADDR         0x42000000
> >>  #define      CONFIG_SYS_LOAD_ADDR    CONFIG_LOADADDR
> >>  #define      CONFIG_OF_LIBFDT
> >> 
> >> +/*
> >> + * Extra Environments
> >> + */
> >> +#define CONFIG_EXTRA_ENV_SETTINGS \
> >> +     "update_sd_firmware_filename=u-boot.sd\0" \
> > 
> > This is still broken, mxsboot doesn't work on mx23.
> 
> Well, yes but I see no reason to not put this here as it will work
> when mxsboot is done. I can hold it if you prefer...

You're adding broken code -- hold it of course. Or split this into two patches

Best regards,
Marek Vasut