[U-Boot] [Patch v3] Consolidate bool type

York Sun yorksun at freescale.com
Wed Jan 23 23:01:49 CET 2013


On 01/23/2013 01:52 PM, Scott Wood wrote:
> On 01/23/2013 03:46:04 PM, York Sun wrote:
>> On 01/23/2013 01:41 PM, York Sun wrote:
>> > 'bool' is defined in random places. This patch consolidates them into a
>> > single header file include/linux/types.h, using stdbool.h.
>> >
>> > All other #define, typedef and enum are removed. They are all
>> consistent with
>> > true = 1, false = 0.
>> >
>> > Signed-off-by: York Sun <yorksun at freescale.com>
>> > ---
>> > Change since v1:
>> >  Move 'false' and 'true' to the common header file.
>> >
>> > Change since v2:
>> >  Use stdbool.h
>> >  Consolidate all TRUE, FALSE, True, False, true, false
>> >
>> > Need help to test on all ARCHs with differnt toolchains as well as
>> USE_PRIVATE_LIBGCC.
>> >
>> >
>> I should put RFC in the subject as I am not able to compile all ARCH
>> myself.
> 
> So how do you see this patch becoming non-RFC?  I think most people
> don't have every single toolchain.  You should at least get a toolchain
> for a couple major architectures such as ARM.  Usually RFC is for when
> you know the patch has issues, and don't want it applied yet even if
> nobody else finds fault with it.
> 

I know this version has problem. I am hoping more people get involved
and test what they can. I tried the arm toolchain you pointed to me. I
couldn't run MAKEALL for arm.

York





More information about the U-Boot mailing list