[U-Boot] [Patch v3] Consolidate bool type

York Sun yorksun at freescale.com
Wed Jan 23 23:04:08 CET 2013


On 01/23/2013 01:53 PM, Scott Wood wrote:
> On 01/23/2013 03:41:47 PM, York Sun wrote:
>> diff --git a/drivers/net/npe/include/IxOsalTypes.h
>> b/drivers/net/npe/include/IxOsalTypes.h
>> index a190a70..0168902 100644
>> --- a/drivers/net/npe/include/IxOsalTypes.h
>> +++ b/drivers/net/npe/include/IxOsalTypes.h
>> @@ -107,18 +107,10 @@ typedef volatile INT32 VINT32;
>>   */
>>  #define IX_OSAL_BILLION (1000000000)
>>
>> -#ifndef TRUE
>> -#define TRUE       1L
>> -#endif
>> -
>>  #if TRUE != 1
>>  #error TRUE is not defined to 1
>>  #endif
>>
>> -#ifndef FALSE
>> -#define FALSE      0L
>> -#endif
>> -
>>  #if FALSE != 0
>>  #error FALSE is not defined to 0
>>  #endif
> 
> I imagine at least one of these #error statements will kick in now.  All
> of the users of non-standard capitalizations must be fixed (I only see
> the definitions affected by this patch), and tests like these should
> just be dropped.
> 


Agreed. Will drop in next version (v5).

York





More information about the U-Boot mailing list