[U-Boot] [RFC Patch v5] Consolidate bool type

Wolfgang Denk wd at denx.de
Thu Jan 24 20:39:37 CET 2013


Dear York Sun,

In message <1359053230-18920-1-git-send-email-yorksun at freescale.com> you wrote:
> 'bool' is defined in random places. This patch consolidates them into a
> single header file include/linux/types.h, using stdbool.h introduced in C99.
> 
> All other #define, typedef and enum are removed. They are all consistent with
> true = 1, false = 0.
> 
> Replace FALSE, False with false. Replace TRUE, True with true.

This patch also includes some type conversions that are unrelated;
these should be split off into a separate commit.

....
> diff --git a/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
> index 00e1c11..4caf3fd 100644
> --- a/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
> +++ b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
> @@ -517,7 +517,7 @@ void fsl_serdes_init(void)
>  	size_t arglen;
>  #endif
>  #ifdef CONFIG_SYS_P4080_ERRATUM_SERDES_A001
> -	int need_serdes_a001;	/* TRUE == need work-around for SERDES A001 */
> +	bool need_serdes_a001;	/* true == need work-around for SERDES A001 */

Like this one...


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It seems intuitively obvious to me, which  means  that  it  might  be
wrong.                                                 -- Chris Torek


More information about the U-Boot mailing list