[U-Boot] [RFC Patch v6] Consolidate bool type

Allen Martin amartin at nvidia.com
Fri Jan 25 02:00:05 CET 2013


On Thu, Jan 24, 2013 at 03:12:17PM -0800, York Sun wrote:
> 'bool' is defined in random places. This patch consolidates them into a
> single header file include/linux/types.h, using stdbool.h introduced in C99.
> 
> All other #define, typedef and enum are removed. They are all consistent with
> true = 1, false = 0.
> 
> Replace FALSE, False with false. Replace TRUE, True with true.
> Skip *.py, *.php, lib/* files.
> 
> Signed-off-by: York Sun <yorksun at freescale.com>
> ---
> Change since v1:
>  Move 'false' and 'true' to the common header file.
> 
> Change since v2:
>  Use stdbool.h
>  Consolidate all TRUE, FALSE, True, False, true, false
> 
> Change since v3:
>  Fix boolean_t which was missed in v2.
> 
> Change since v4:
>  Replace FALSE, False with false. Replace TRUE, True with true.
> 
> Change since v5:
>  Revert changes for *.py, *.php, lib/* files.
>  Revert change to type conversions.
>  Revert comment-only changes. (Not sure about if we should replace the comments).
>  Fix many coding style issues but left drivers/net/npe alone (way too many issues).
> 
> This patch doesn't address the white space issue where TRUE/FALSE is repalced.
> 
> Need help to test on all ARCHs with differnt toolchains as well as USE_PRIVATE_LIBGCC.

I think you can drop the RFC from your patch at this point.

Built on all tegra20 and tegra30 devices with USE_PRIVATE_LIBGCC.
Tested on seaboard (tegra20).

I've also submitted your patch to my build regression script which
will build all 1100+ boards against your patch and tell if there are
any build regressions.  I'll let you know the results tomorrow.

-Allen
-- 
nvpublic


More information about the U-Boot mailing list