[U-Boot] [PATCH v2 0/7] Move Tegra EHCI drive to correct place

Lucas Stach dev at lynxeye.de
Fri Jan 25 17:19:16 CET 2013


Hello Tom,

Am Freitag, den 25.01.2013, 08:07 -0800 schrieb Tom Warren:
> I tried to apply this to u-boot-tegra/next and it needed some massaging to get it to apply cleanly. Minor stuff, but you'll need to rebase it on top of current u-boot-tegra/next (I just pushed a new version with my 'Move common clock code' patch and Allen's fix for the DTS sort patch. Sorry, but the Tegra repo is going to be fairly dynamic for the next few weeks.
> 
Ok, I'll wait for some comments on the actual code, then repost a
rebased version.

> Also, when I did get it applied and tried to ./MAKEALL -s tegra20 -s tegra30, I got the following warning on all T20 builds:
> 
> ehci-tegra.c: In function 'ehci_hcd_init':
> ehci-tegra.c:565: warning: assignment makes pointer from integer without a cast
> ehci-tegra.c:566: warning: assignment makes pointer from integer without a cast
> 
Ah damn, forgot to squash the fix in the last patch.

> Also, it appears that arch-tegra20/usb.h is still hanging around (in my edited patch series, at any rate). Shouldn't the moved arch-tegra/usb.h be used exclusively? Removing arch-tegra20/usb.h causes fatal errors in nvidia/common/board.c. If it does need to exist, then it needs to live in arch-tegra30, also, so it'll be available when T30 gets USB turned on.

I don't see why this is happening. The shortlog points at git picking up
the rename at the in the wrong dir, I'll look into this when reposting.
But the change to nvidia/common/board.c to use the new include dir is
definitely included in patch 6.

Regards,
Lucas





More information about the U-Boot mailing list