[U-Boot] [PATCH 02/10] lcd, tegra: remove unused cursor functions

[Tom Warren]

Jeroen,

How will this all go in? Do you expect Anatolij to take it in via the main repo (u-boot.git/master)?

LGTM, BTW

Tom

> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: Friday, January 25, 2013 1:38 PM
> To: Jeroen Hofstee
> Cc: u-boot at lists.denx.de; Tom Warren
> Subject: Re: [U-Boot] [PATCH 02/10] lcd, tegra: remove unused cursor
> functions
> 
> +Tom
> 
> On Sun, Jan 13, 2013 at 11:07 AM, Jeroen Hofstee <jeroen at myspectrum.nl>
> wrote:
> > cc: Anatolij Gustschin <agust at denx.de>
> > cc: Simon Glass <sjg.chromium.org>
> > Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>
> 
> Acked-by: Simon Glass <sjg at chromium.org>
> 
> > ---
> >  drivers/video/tegra.c |   52 -------------------------------------------------
> >  1 file changed, 52 deletions(-)
> >
> > diff --git a/drivers/video/tegra.c b/drivers/video/tegra.c index
> > 3709d0b..26a96a5 100644
> > --- a/drivers/video/tegra.c
> > +++ b/drivers/video/tegra.c
> > @@ -73,62 +73,10 @@ vidinfo_t panel_info = {
> >         .vl_col = -1,
> >  };
> >
> > -char lcd_cursor_enabled;
> > -
> > -ushort lcd_cursor_width;
> > -ushort lcd_cursor_height;
> > -
> >  #ifndef CONFIG_OF_CONTROL
> >  #error "You must enable CONFIG_OF_CONTROL to get Tegra LCD support"
> >  #endif
> >
> > -void lcd_cursor_size(ushort width, ushort height) -{
> > -       lcd_cursor_width = width;
> > -       lcd_cursor_height = height;
> > -}
> > -
> > -void lcd_toggle_cursor(void)
> > -{
> > -       ushort x, y;
> > -       uchar *dest;
> > -       ushort row;
> > -
> > -       x = console_col * lcd_cursor_width;
> > -       y = console_row * lcd_cursor_height;
> > -       dest = (uchar *)(lcd_base + y * lcd_line_length + x * (1 << LCD_BPP) /
> > -                       8);
> > -
> > -       for (row = 0; row < lcd_cursor_height; ++row, dest += lcd_line_length)
> {
> > -               ushort *d = (ushort *)dest;
> > -               ushort color;
> > -               int i;
> > -
> > -               for (i = 0; i < lcd_cursor_width; ++i) {
> > -                       color = *d;
> > -                       color ^= lcd_getfgcolor();
> > -                       *d = color;
> > -                       ++d;
> > -               }
> > -       }
> > -}
> > -
> > -void lcd_cursor_on(void)
> > -{
> > -       lcd_cursor_enabled = 1;
> > -       lcd_toggle_cursor();
> > -}
> > -void lcd_cursor_off(void)
> > -{
> > -       lcd_cursor_enabled = 0;
> > -       lcd_toggle_cursor();
> > -}
> > -
> > -char lcd_is_cursor_enabled(void)
> > -{
> > -       return lcd_cursor_enabled;
> > -}
> > -
> >  static void update_panel_size(struct fdt_disp_config *config)  {
> >         panel_info.vl_col = config->width;
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
--
nvpublic