[U-Boot] [PATCH v3 2/2] mx23_olinuxino: Add support for status LED

[Marek Vasut]

Dear Otavio Salvador,

> On Mon, Jan 28, 2013 at 1:18 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Otavio Salvador,
> > 
> >> On Mon, Jan 28, 2013 at 1:10 PM, Marek Vasut <marex at denx.de> wrote:
> >> > Dear Otavio Salvador,
> >> > 
> >> > [..]
> >> > 
> >> >>  /*
> >> >> 
> >> >> + * Status LED
> >> >> + */
> >> >> +#define      CONFIG_STATUS_LED
> >> >> +#define      CONFIG_GPIO_LED
> >> >> +#define      CONFIG_BOARD_SPECIFIC_LED
> >> >> +#define      STATUS_LED_BOOT 0
> >> >> +#define      STATUS_LED_BIT  0x030a /*
> >> >> MX23_PAD_SSP1_DETECT__GPIO_2_1 */
> >> > 
> >> > Just use MX23_PAD_SSP1_DETECT__GPIO_2_1 directly ?
> >> 
> >> make[1]: Nothing to be done for `all'.
> >> make[1]: Leaving directory `/home/otavio/hacking/u-boot/drivers/mtd/spi'
> >> status_led.c:46:7: error: 'MX23_PAD_SSP1_DETECT__GPIO_2_1' undeclared
> >> here (not in a function)
> > 
> > #include iomux-mx23 missing ?
> 
> ...
> make[1]: Entering directory `/home/otavio/hacking/u-boot/tools'
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h: Assembler messages:
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h:38: Error: bad
> instruction `typedef u32 iomux_cfg_t'
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h:112: Error: bad
> instruction `static inline unsigned int PAD_BANK(iomux_cfg_t pad)'
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h:113: Error: junk
> at end of line, first unrecognized character is `{'
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h:114: Error: bad
> instruction `return (pad&((iomux_cfg_t)0x7<<0))>>0'
> ...
> 
> I had try it before of course ;)

So iomux.h is not safe to be included in assembler fixes ... fix it with some 
ifdef __ASSEMBLY__ as the rest of the header files are .

Best regards,
Marek Vasut