[U-Boot] [PATCH v4 2/3] mxs: Fix iomux.h to not break build during assembly stage
Marek Vasut
marex at denx.de
Mon Jan 28 17:16:46 CET 2013
Dear Otavio Salvador,
> On Mon, Jan 28, 2013 at 1:57 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Otavio Salvador,
> >
> > Missing commit message.
>
> I think short description is clear enough. What you'd like me to put
> in long one?
Reasoning why this patch is necessary.
> >> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
> >> ---
> >> Changes in v4:
> >> - New patch
> >>
> >> Changes in v3: None
> >> Changes in v2: None
> >>
> >> arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h
> >> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644
> >> --- a/arch/arm/include/asm/arch-mxs/iomux.h
> >> +++ b/arch/arm/include/asm/arch-mxs/iomux.h
> >> @@ -21,6 +21,10 @@
> >>
> >> #ifndef __MACH_MXS_IOMUX_H__
> >> #define __MACH_MXS_IOMUX_H__
> >>
> >> +#ifndef __ASSEMBLY__
> >> +
> >> +#include <asm/types.h>
> >> +
> >
> > Is this needed?
>
> Yes; or I would not have added it right? :)
Why is it needed?
> >> /*
> >>
> >> * IOMUX/PAD Bit field definitions
> >> *
> >>
> >> @@ -165,4 +169,5 @@ int mxs_iomux_setup_pad(iomux_cfg_t pad);
> >>
> >> */
> >>
> >> int mxs_iomux_setup_multiple_pads(const iomux_cfg_t *pad_list, unsigned
> >>
> >> count);
> >>
> >> +#endif /* __ASSEMBLY__ */
> >>
> >> #endif /* __MACH_MXS_IOMUX_H__*/
> >
> > Best regards,
> > Marek Vasut
>
> --
> Otavio Salvador O.S. Systems
> E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
> Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Best regards,
Marek Vasut
More information about the U-Boot
mailing list