[U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support

Otavio Salvador otavio at ossystems.com.br
Mon Jan 28 21:03:16 CET 2013


On Mon, Jan 28, 2013 at 5:56 PM, Marek Vasut <marex at denx.de> wrote:
> Dear Fabio Estevam,
>
>> On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador
>>
>> <otavio at ossystems.com.br> wrote:
>> > +#ifdef CONFIG_CMD_NET
>> > +int board_eth_init(bd_t *bis)
>> > +{
>> > +       /* Power-on Ethernet */
>> > +       gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
>> > +}
>> > +#endif
>>
>> This function expects to return an integer, and there is no return value
>> here.
>>
>> Also, maybe you could set the GPIO inside board_early_init_f() like we
>> do on mx28.
>
> How come it didn't emit an error?

It works; I tested it and sent the new patch version with it.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br


More information about the U-Boot mailing list