[U-Boot] [PATCH v2 4/4] mx23_olinuxino: Add ethernet support

Otavio Salvador otavio at ossystems.com.br
Mon Jan 28 21:15:51 CET 2013


On Mon, Jan 28, 2013 at 6:12 PM, Fabio Estevam <festevam at gmail.com> wrote:
> On Mon, Jan 28, 2013 at 6:01 PM, Otavio Salvador
> <otavio at ossystems.com.br> wrote:
>> This adds support to the LAN9212 chip included in the board and extend

> My schematics says it is a LAN9512.

Right; a typo!

>> +#ifdef CONFIG_USB_EHCI
>> +       /* Enable LAN9512 */
>> +       gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
>> +#endif
>
> You would better use #ifdef     CONFIG_CMD_USB instead, like we do on mx28evk.
>
> This would make things easier for someone that wants to test the board
> without USB support, by just undefing CONFIG_CMD_USB, which in turn
> remove all USB related support.

Done; v3 being rolling out ... :)

--
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br


More information about the U-Boot mailing list