[U-Boot] [PATCH V1 4/7] lcd: add option for board specific splash screen preparation

Nikita Kiryanov nikita at compulab.co.il
Tue Jan 29 15:44:48 CET 2013


Hi Wolfgang Denk,

On 01/29/2013 03:46 PM, Wolfgang Denk wrote:
> Dear Nikita Kiryanov,
>
> In message <1359463349-11649-5-git-send-email-nikita at compulab.co.il> you wrote:
>> Currently there is no logical place to put the code that prepares the
>> splash image data. The splash image data should be ready in memory
>> before bmp_display() is called, and after the environment is ready
>> (since lcd.c looks for the splash image in an address specified by
>> the environment variable "splashimage").
>>
>> Our window of opportunity in board_init_r() is therefore: between
>> env_relocate() and bmp_display(), and from the available options
>> only the lcd related functions in drv_lcd_init() seem appropriate
>> for such lcd oriented code.
>>
>> Add the option to prepare the splash image data in lcd_logo() right
>> before it is sent to be displayed.
>>
>> Signed-off-by: Nikita Kiryanov <nikita at compulab.co.il>
>> Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>
>
> You should add the video custodian on Cc: for such patches.
>
> [Done here].

Will do...
I did Cc Anatolij when running git send-patch though...
It's possible that it was dropped by mailman (see this discussion:
http://www.mail-archive.com/u-boot@lists.denx.de/msg103585.html)
but he should still get the email.

Anyway, I'll start using the Cc line in the patches as requested..

>
> Best regards,
>
> Wolfgang Denk
>


-- 
Regards,
Nikita.


More information about the U-Boot mailing list