[U-Boot] [PATCH 10/10] mx23_olinuxino: Add ethernet support

Marek Vasut marex at denx.de
Wed Jan 30 17:16:29 CET 2013


Dear Otavio Salvador,

> On Wed, Jan 30, 2013 at 2:06 PM, Marek Vasut <marex at denx.de> wrote:
> > Dear Otavio Salvador,
> > 
> > [...]
> > 
> >> >> In this case I'd prefer to add support for the hub only in the
> >> >> previous patch and left the ethernet support on this with the env.
> >> >> 
> >> >> Makes sense?
> >> > 
> >> > The hub and the ethernet are the same chip, thus it makes no sense to
> >> > have two patches for that.
> >> 
> >> I'd like to have all changes of ethernet in a single commit so the
> >> enviroment and all the other changes for it in one logical change. I
> >> agree about the hub but the ethernet does not seem right to merge it
> >> there.
> > 
> > This will then be completely un-bisectable.
> 
> I will prepare the patches for v2 and we check how it goes. :)

Cool your jets already ... re-submit only upon request.

Best regards,
Marek Vasut


More information about the U-Boot mailing list