[U-Boot] [PATCH] arm: fix bug on relocation address

Jeroen Hofstee jeroen at myspectrum.nl
Thu Jan 31 20:08:02 CET 2013


Hello Luca,

On 01/31/2013 03:29 PM, Luca Ellero wrote:
> If (N. SDRAM banks > 1) and they are not contiguous, don't relocate
> u-boot at (CONFIG_SYS_SDRAM_BASE + gd->ram_size), which is a bug.
> Instead use the end of 2nd bank (even if there are more than 2 banks)
>
> Signed-off-by: Luca Ellero <lroluk at gmail.com>
> Cc: Albert Aribaud <albert.u.boot at aribaud.net>
> Cc: Heiko Schocher <hs at denx.de>
> ---
>
> On ARM architectures there is a bug getting top of SDRAM (where u-boot
> will be relocated). Top of SDRAM will always be:
>
> CONFIG_SYS_SDRAM_BASE + gd->ram_size
>
> anyway this can be wrong since SDRAM can be composed by more that one
> bank in not-contiguous address space.
I don't think this is a valid use case since the README says:

"The available memory is mapped to fixed addresses using the memory
controller. In this process, a contiguous block is formed for each
memory type (Flash, SDRAM, SRAM), even when it consists of several
physical memory banks."

Regards,
Jeroen




More information about the U-Boot mailing list