[U-Boot] [PATCH v2] Add support for Wandboard quad.

Wolfgang Denk wd at denx.de
Mon Jun 3 13:21:54 CEST 2013


Dear Stefano Babic,

In message <51AC61A6.9050609 at denx.de> you wrote:
> 
> It is better to fix it directly into this patch. Can you fix it by
> casting to phys_size_t and resubmit ?
> 
> 	gd->ram_size = (phys_size_t)CONFIG_DDR_MB * SZ_1M;

Please do NOT use these terrible  SZ_*  defines.  Never, ever.

They are dangerous and should be avoided.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Carelessly planned projects take three times longer to complete  than
expected.  Carefully  planned  projects  take  four  times  longer to
complete than expected, mostly  because  the  planners  expect  their
planning to reduce the time it takes.


More information about the U-Boot mailing list