[U-Boot] [PATCH v2] Add support for Wandboard quad.

Otavio Salvador otavio at ossystems.com.br
Mon Jun 3 13:25:18 CEST 2013


On Mon, Jun 3, 2013 at 8:21 AM, Wolfgang Denk <wd at denx.de> wrote:

> Dear Stefano Babic,
>
> In message <51AC61A6.9050609 at denx.de> you wrote:
> >
> > It is better to fix it directly into this patch. Can you fix it by
> > casting to phys_size_t and resubmit ?
> >
> >       gd->ram_size = (phys_size_t)CONFIG_DDR_MB * SZ_1M;
>
> Please do NOT use these terrible  SZ_*  defines.  Never, ever.
>
> They are dangerous and should be avoided.
>

Do you mind to explain why?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the U-Boot mailing list