[U-Boot] [PATCH v1 1/1] mpc512x: adjust and improve AC14xx board support

[Gerhard Sittig]

On Mon, Jun 03, 2013 at 15:07 +0200, Wolfgang Denk wrote:
> 
> In message <1370257851-27583-1-git-send-email-gsi at denx.de> you wrote:
> >
> > +		if (mac_diag)
> > +			printf("DIAG: MAC [%s]\n", getenv("ethaddr"));
> 
> What happens if "ethaddr" is not defined in the environment?

The context is the mac_read_from_eeprom() routine, and the
getenv() call for the message is immediately preceeded by a
setenv() call.

Right, the lookup may fail if the setup failed as well.  That's a
yet uncaught followup failure.  Will include an improved check in
v2 of the patch.

> ...
> > +	"rootpath=/opt/eldk/ppc_6xx\0"					\
> 
> You are really still using ELDK 4.x ?

In this specific project?  Yes!  Although development setups used
to run with both 4.2 and 5.3 here for some time, the evaluation
hasn't comleted yet, so the final switch wasn't made so far.

I'll look into what else is involved in the ELDK-5 switch (using
a mere symlink here from under /opt/eldk/ppc_6xx-sign to
/opt/eldk-5.3/powerpc/rootfs-*), although /opt/eldk itself may
perfectly legally be a symlink to /opt/eldk-5.3 for those setups
which want to switch back and forth.  Wasn't this the usual
approach before ELDK-5?  Somehow I'm reluctant to encode the ELDK
version into the binary, hmm ...


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de