[U-Boot] [PATCH v1 1/1] mpc512x: adjust and improve AC14xx board support

[Wolfgang Denk]

Dear Gerhard Sittig,

In message <20130603135004.GH2571 at book.gsilab.sittig.org> you wrote:
>
> > > +		if (mac_diag)
> > > +			printf("DIAG: MAC [%s]\n", getenv("ethaddr"));
> > 
> > What happens if "ethaddr" is not defined in the environment?
> 
> The context is the mac_read_from_eeprom() routine, and the
> getenv() call for the message is immediately preceeded by a
> setenv() call.

...which, as everything, can fail for a number of reasons.

It is utterly wrong to rely on results of any previous actions and
assume that nothing can go wrong.  Murphy will teach you.

> > > +	"rootpath=/opt/eldk/ppc_6xx\0"					\
> > 
> > You are really still using ELDK 4.x ?
> 
> In this specific project?  Yes!  Although development setups used
> to run with both 4.2 and 5.3 here for some time, the evaluation
> hasn't comleted yet, so the final switch wasn't made so far.

...which makes clear that setting such variables in the default config
is of questionable value.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
By the way, ALL software projects are done by iterative  prototyping.
Some companies call their prototypes "releases", that's all.