[U-Boot] arm, arm335x: add watchdog support

Heiko Schocher hs at denx.de
Wed Jun 5 16:17:41 CEST 2013


Hello Michael,

Am 05.06.2013 15:31, schrieb Michael Trimarchi:
> Hi
> 
> On Jun 4, 2013 10:55 AM, "Heiko Schocher" <hs at denx.de <mailto:hs at denx.de>> wrote:
>>
>> Add TI OMAP 16xx & 24xx/34xx 32KHz (non-secure) watchdog support.
>>
>> Signed-off-by: Heiko Schocher <hs at denx.de <mailto:hs at denx.de>>
>> Cc: Albert Aribaud <albert.u.boot at aribaud.net <mailto:albert.u.boot at aribaud.net>>
>> Cc: Tom Rini <trini at ti.com <mailto:trini at ti.com>>
>> ---
>>  arch/arm/include/asm/arch-am33xx/cpu.h |  20 ++++++
>>  drivers/watchdog/Makefile              |   1 +
>>  drivers/watchdog/omap_wdt.c            | 115 +++++++++++++++++++++++++++++++++
>>  3 Dateien geändert, 136 Zeilen hinzugefügt(+)
>>  create mode 100644 drivers/watchdog/omap_wdt.c
[...]
>> diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c
>> new file mode 100644
>> index 0000000..dc4df98
>> --- /dev/null
>> +++ b/drivers/watchdog/omap_wdt.c
>> @@ -0,0 +1,115 @@
[...]
>> +       /* wait for posted write to complete */
>> +       while ((readl(&wdt->wdtwwps) & WDT_WWPS_PEND_WTGR))
>> +               ;
>> +}
>> +
> 
> I think that this patch has some problem because watchdog reset is in getc code. Did you try to paste very long string when it is enabled? You need to
> avoid reset when it is not needed

I think, I do not understand you ... this is for all watchdogs
the case ...

I currently pasted a 500 bytes long string, seeing no problems
with the watchdog...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list