[U-Boot] [PATCH] vf610twr: Drop unneeded 'or' operator

Otavio Salvador otavio at ossystems.com.br
Wed Jun 5 23:42:16 CEST 2013


On Wed, Jun 5, 2013 at 6:24 PM, Benoît Thébaudeau <
benoit.thebaudeau at advansee.com> wrote:

> Hi Fabio,
>
> On Wednesday, June 5, 2013 11:17:45 PM, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam at freescale.com>
> >
> > No need to use the or operator, so just remove it.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> > ---
> >  board/freescale/vf610twr/vf610twr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/board/freescale/vf610twr/vf610twr.c
> > b/board/freescale/vf610twr/vf610twr.c
> > index 04fa882..1156194 100644
> > --- a/board/freescale/vf610twr/vf610twr.c
> > +++ b/board/freescale/vf610twr/vf610twr.c
> > @@ -308,7 +308,7 @@ int board_mmc_init(bd_t *bis)
> >       imx_iomux_v3_setup_multiple_pads(
> >               esdhc1_pads, ARRAY_SIZE(esdhc1_pads));
> >
> > -     status |= fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
> > +     status = fsl_esdhc_initialize(bis, &esdhc_cfg[0]);
> >
> >       return status;
> >  }
> > --
> > 1.8.1.2
>
> Or even better, completely drop status and use
> "return fsl_esdhc_initialize(bis, &esdhc_cfg[0]);".
>

+1 :)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://projetos.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


More information about the U-Boot mailing list