[U-Boot] [PATCH 4/7] mmc: Update the handling of returned erase block

Jaehoon Chung jh80.chung at samsung.com
Fri Nov 8 02:29:22 CET 2013


Dear Haijun,

Check the below message, plz.

cmd_mmc.c: In function ‘do_mmcops’:
cmd_mmc.c:405:5: warning: comparisons like ‘X<=Y<=Z’ do not have their mathematical meaning [-Wparentheses]
cmd_mmc.c:406:5: warning: comparisons like ‘X<=Y<=Z’ do not have their mathematical meaning [-Wparentheses]
cmd_mmc.c:407:4: warning: comparisons like ‘X<=Y<=Z’ do not have their mathematical meaning [-Wparentheses]

Best Regards,
Jaehoon Chung

On 11/05/2013 03:23 PM, Haijun Zhang wrote:
> If the block rang was not algined, We tried to algined the range,
> then erase the block. So the block range erased should be less or
> equal to the block range send. If error occured during erase procedure
> part of them will be erased. And use should resend the block rang to
> continue erase the reset of them.
> 
> Error number and zero number mean erase operation was failed.
> 
> Signed-off-by: Haijun Zhang <haijun.zhang at freescale.com>
> ---
>  common/cmd_mmc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c
> index 67a94a7..15cecb7 100644
> --- a/common/cmd_mmc.c
> +++ b/common/cmd_mmc.c
> @@ -397,6 +397,13 @@ static int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  			BUG();
>  		}
>  
> +		if (state == MMC_ERASE) {
> +			printf("%d blocks %s: %s\n",
> +				(cnt >= n > 0) ? n : 0, argv[1],
> +				(cnt >= n > 0) ? "OK" : "ERROR");
> +			return (cnt >= n > 0) ? 0 : 1;
> +		}
> +
>  		printf("%d blocks %s: %s\n",
>  				n, argv[1], (n == cnt) ? "OK" : "ERROR");
>  		return (n == cnt) ? 0 : 1;
> 



More information about the U-Boot mailing list