[U-Boot] [PATCH 4/4] M68k:Update the DSPI interface based on the new DSPI driver.

Chao Fu B44548 at freescale.com
Mon Nov 18 10:26:58 CET 2013


Dear  Stefano 
Excuse me, I could not understand your mean absolutely clear.
I have tested all the four patches on Coldfire platforms. 
Because only DSPI module is re-use on the two platforms , Coldfire is earlier,
Only change config name of DSPI. 
Do you mean I should rename other modules config names in Coldfire?
Could you give me some detail examples?
Thank you very much!

 Best regards,
 Fu Chao

> Hi Chao,
> 
> On 18/11/2013 07:34, Chao Fu wrote:
> > From: Chao Fu <B44548 at freescale.com>
> >
> > Freescale DSPI module is used on both the ColdFire platform and the
> > ARM platform. There is patch-set to make the driver re-used by both
> platforms.
> > Some files and macro were changed accordingly, this patch follow those
> > changes to update the macro and include file for some ColdFire boards.
> >
> > The updates include:
> > Rename the CONFIG_CF_DSPI to CONFIG_FSL_DSPI.
> > Add the get_dspi_clk function for ColdFire platform.
> >
> 
> I have not tested, but it seems you break Coldfire platform with previous
> patches until this patch is not applied. This makes the tree not
> bisectable. Is Coldfire buildable after applying only 1/4 ?
> 
> IMHO you should change the coldifire platform together with moving and
> renaming the driver to avoid breakages.
> 
> Best regards,
> Stefano Babic
> 
> 
> --
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
> =====================================================================




More information about the U-Boot mailing list