[U-Boot] [PATCH 4/4] M68k:Update the DSPI interface based on the new DSPI driver.

[Stefano Babic]

Hi Chao,

On 18/11/2013 10:26, Chao Fu wrote:
> Dear  Stefano 
> Excuse me, I could not understand your mean absolutely clear.
> I have tested all the four patches on Coldfire platforms. 

I have not tested at all and I can be wrong - so I try to be more clear.
It is clear that after applying all patches the Coldfire platform is not
broken - this is not the point.

> Because only DSPI module is re-use on the two platforms , Coldfire is earlier,
> Only change config name of DSPI. 
> Do you mean I should rename other modules config names in Coldfire?
> Could you give me some detail examples?

The question is what happen when the 4/4 patch is not applied. It seems
no me that Coldfire are broken, because they reference to a driver that
does not exist anymore. Is it ?

Of course, all patches will be applied if they are ok after review - but
this can make the tree not bisectable.

In fact, if looking at a problem we run "git bisect" and the tree is set
to 3/4 of your patchset, the Coldfire platform results broken when we
try to build.

For this reason I find better if you update the interface (this patch)
together with moving the driver. The change in config name reflects then
at the same time with the new driver name and the Coldfire platform is
not broken.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================