[U-Boot] [PATCH v10 2/4] mtd: nand: omap: enable BCH ECC scheme using ELM for generic platform

Scott Wood scottwood at freescale.com
Thu Nov 21 01:14:54 CET 2013


On Wed, 2013-11-20 at 04:09 +0000, Gupta, Pekon wrote:
> > From: Scott Wood [mailto:scottwood at freescale.com]
> > On Mon, 2013-11-18 at 19:03 +0530, Pekon Gupta wrote:
> > > @@ -763,77 +903,47 @@ static void __maybe_unused
> > omap_free_bch(struct mtd_info *mtd)
> > >   * @eccstrength		- the number of bits that could be corrected
> > >   *			  (1 - hamming, 4 - BCH4, 8 - BCH8, 16 - BCH16)
> > >   */
> > > -void omap_nand_switch_ecc(uint32_t hardware, uint32_t eccstrength)
> > > +int __maybe_unused omap_nand_switch_ecc(uint32_t hardware,
> > uint32_t eccstrength)
> > >  {
> > >  	struct nand_chip *nand;
> > >  	struct mtd_info *mtd;
> > > +	struct nand_bch_priv *bch;
> > > +	int err = 0;
> > 
> > bch gives unused warning
> > 
> Sorry, I would have missed it.. I would clean this.

If that's the only issue, I can resolve it when applying.

> > I tried to see if the warning goes away later, but patch 3/4 doesn't
> > apply cleanly.  What tree is this patchset against?
> > 
> These patches should apply cleanly on 
> 	git://git.denx.de/u-boot.git  master
> Do you have any other tree on which you want me to re-base ?

Never mind -- I had some old reject files that made me think the
conflict was in files that I hadn't touched yet (such as omap_gpmc.c),
but the only conflict was in include/config/tricorder.h which I had
touched in an earlier patch.

-Scott





More information about the U-Boot mailing list