[U-Boot] [PATCH 01/11] fw_env.c: Increase max dev path to 32

Wolfgang Denk wd at denx.de
Sat Oct 5 22:02:12 CEST 2013


Dear Tom Rini,

In message <1380227287-26057-2-git-send-email-trini at ti.com> you wrote:
> Currently our limit is too small to allow for /dev/mmcblk0boot0 to work,
> for example.  Expand to 32 for future needs.
> 
> Signed-off-by: Tom Rini <trini at ti.com>
> ---
>  tools/env/fw_env.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
> index 577ce2d..bf5c552 100644
> --- a/tools/env/fw_env.c
> +++ b/tools/env/fw_env.c
> @@ -40,7 +40,7 @@
>  	_min1 < _min2 ? _min1 : _min2; })
>  
>  struct envdev_s {
> -	char devname[16];		/* Device name */
> +	char devname[32];		/* Device name */

Do we really need a static size here?  Can we not auto-adjust to the
needed size, say by dynamically allocating the buffer?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The speed of time is one second per second.


More information about the U-Boot mailing list