[U-Boot] [PATCH 01/11] fw_env.c: Increase max dev path to 32
Tom Rini
trini at ti.com
Sun Oct 6 22:55:27 CEST 2013
On Sat, Oct 05, 2013 at 10:02:12PM +0200, Wolfgang Denk wrote:
> Dear Tom Rini,
>
> In message <1380227287-26057-2-git-send-email-trini at ti.com> you wrote:
> > Currently our limit is too small to allow for /dev/mmcblk0boot0 to work,
> > for example. Expand to 32 for future needs.
> >
> > Signed-off-by: Tom Rini <trini at ti.com>
> > ---
> > tools/env/fw_env.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/env/fw_env.c b/tools/env/fw_env.c
> > index 577ce2d..bf5c552 100644
> > --- a/tools/env/fw_env.c
> > +++ b/tools/env/fw_env.c
> > @@ -40,7 +40,7 @@
> > _min1 < _min2 ? _min1 : _min2; })
> >
> > struct envdev_s {
> > - char devname[16]; /* Device name */
> > + char devname[32]; /* Device name */
>
> Do we really need a static size here? Can we not auto-adjust to the
> needed size, say by dynamically allocating the buffer?
Doesn't look like it, without a big change to the parsing code.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131006/9efb8269/attachment.pgp>
More information about the U-Boot
mailing list