[U-Boot] [PATCH] Subject: [PATCH v.2] at91: add support for CDU9G25 board

Wolfgang Denk wd at denx.de
Mon Sep 9 17:34:31 CEST 2013


Dear Jiri Prchal,

In message <1378736524-30870-1-git-send-email-jiri.prchal at aksignal.cz> you wrote:
> This patch adds support for our companies board CDU9G25 with Atmel AT91SAM9G25, 128MB DDR2, 256MB NAND.

Please keep the line length of the commit message < 70 characters.

> v.2
> Fixed static IP and MAC addr cofiguration by random MAC and DHCP.
> Added entry to MAINTAINERS.
> Fixed line lenght, trailing spaces and other cosmetics.

This comment does not belong into the commit message - please move it
to the comment section, i. e. below the "---" line.

> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -939,6 +939,9 @@ Bo Shen <voice.shen at atmel.com>
>  	at91sam9x5ek		ARM926EJS (AT91SAM9G15,G25,G35,X25,X35 SoC)
>  	sama5d3xek		ARMV7 (SAMA5D31, D33, D34, D35 SoC)
> 
> +Jiri Prchal <jiri.prchal at aksignal.cz>
> +	cdu9g25			ARM926EJS (AT91SAM9G25 SoC)
> +
>  Rajeshwari Shinde <rajeshwari.s at samsung.com>

Please keep the list sorted.


> +#define CONFIG_BOOTARGS		"console=ttyS0,115200 ubi.mtd=root"\
> +				"root=ubi0:root rootfstype=ubifs rw"\
> +				"g_ether.dev_addr=02:04:25:aa:55:5e"\
> +				"g_ether.host_addr=02:04:25:aa:55:5f"
> +#define CONFIG_SERVERIP		10.0.1.1

We do not allow static network configuration in board config files!
Please get rid of these MAC and IP addresses here.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The project was large enough and management communication poor enough
to prompt many members of the team to see themselves  as  contestants
making  brownie  points,  rather  than as builders making programming
products. Each suboptimized  his  piece  to  meet  his  targets;  few
stopped to think about the total effect on the customer.
                              - Fred Brooks, "The Mythical Man Month"


More information about the U-Boot mailing list