[U-Boot] [PATCH] usb: ehci: Fix test mode for connected ports

Simon Glass sjg at chromium.org
Fri Sep 20 07:12:46 CEST 2013


Hi Julius,


On Thu, Sep 19, 2013 at 7:39 PM, Julius Werner <jwerner at chromium.org> wrote:

> Hello Marek,
>
> 8 seemed like a reasonable value. It is not the only possible one. As
> I said, the spec requires a minimum of 4.125 (125us to make sure the
> current microframe finishes, and 16 * 125us to wait for the 16 full
> microframes listed on page 20). 8 fulfills that constraint and leaves
> a little more tolerance, but you could also use 5, 16 or 100. I really
> don't care, so please just tell me what number you want to have if you
> don't like 8, because it just doesn't matter. It is no more or less
> magic than the 100ms used in most other handshake() calls (without any
> #define or explanation).
>

It seems like you could do something like

/*
 * This is the delay for ...the spec requires a minimum of ...
 */
#define SOME_SUITABLE_NAME 8000

at the top of the file and then use it twice in your function.

Regards,
Simon


More information about the U-Boot mailing list