[U-Boot] [PATCH] usb: ehci: Fix test mode for connected ports

Julius Werner jwerner at chromium.org
Tue Sep 24 04:55:02 CEST 2013


Hi Simon,

> It seems like you could do something like
>
> /*
>  * This is the delay for ...the spec requires a minimum of ...
>  */
> #define SOME_SUITABLE_NAME 8000
>
> at the top of the file and then use it twice in your function.

The file contains a dozen handshake() calls that have a literal "100 *
1000" in there, and none of them have any special meaning in regards
to the spec... it's all just a random guess. I'd be happy to change
the timeouts in my patch to 100 for consistency, but it really doesn't
make sense to single this one out with a #define. (Maybe we should
make it a #define DEFAULT_TIMEOUT 100000 for all of them, but not in
this patch.)


More information about the U-Boot mailing list