[U-Boot] [PATCH v3 13/13] common: fixed linker-list example

Lukasz Majewski l.majewski at samsung.com
Tue Apr 1 09:42:40 CEST 2014


Hi Marek,

> On Monday, March 31, 2014 at 05:49:12 PM, Mateusz Zalega wrote:
> > Change-Id: Id1bab29ec026d83f7e811ba82802aad33f77bea0

Yes, definitely :-). 
Those Change-Ids are a PITA.

> 
> You samsung guys need to fix your mailers ... and you need to learn
> to write commit messages.
> 
> > Signed-off-by: Mateusz Zalega <m.zalega at samsung.com>
> > Cc: Marek Vasut <marex at denx.de>
> > Cc: Tom Rini <trini at ti.com>
> 
> Other than that, please add this for V2:
> 
> Acked-by: Marek Vasut <marex at denx.de>
> 
> > ---
> >  include/linker_lists.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/linker_lists.h b/include/linker_lists.h
> > index 997d149..557e627 100644
> > --- a/include/linker_lists.h
> > +++ b/include/linker_lists.h
> > @@ -228,7 +228,7 @@
> >   * and it's name.
> >   *
> >   * Example:
> > - * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub,
> > cmd.sub) = {
> > + * ll_entry_declare(struct my_sub_cmd, my_sub_cmd, cmd_sub) = {
> >   *         .x = 3,
> >   *         .y = 4,
> >   * };
> 
> Best regards,
> Marek Vasut


-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list