[U-Boot] [PATCH] buildman: make output dir configurable

[Simon Glass]

Hi Daniel,

On 28 March 2014 14:46, Daniel Schwierzeck <daniel.schwierzeck at gmail.com>wrote:

> Add an option to specify the output directory to override the
> default path '../'. This is useful for building in a ramdisk.
>
> Signed-off-by: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> ---
>  tools/buildman/buildman.py | 2 ++
>  tools/buildman/control.py  | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/buildman/buildman.py b/tools/buildman/buildman.py
> index 8822efe..0d95246 100755
> --- a/tools/buildman/buildman.py
> +++ b/tools/buildman/buildman.py
> @@ -101,6 +101,8 @@ parser.add_option('-T', '--threads', type='int',
>         default=None, help='Number of builder threads to use')
>  parser.add_option('-u', '--show_unknown', action='store_true',
>         default=False, help='Show boards with unknown build result')
> +parser.add_option('-o', '--output-dir', type='string',
> +       dest='output_dir', default='..', help='Output directory')
>

Can you expand the help here a bit? This is the directory where all the
builds happen, with a separate sub-directory for each commit. It also holds
the working directory (.bm-work). So maybe 'Build output directory, also
used for working space' ?


>
>  parser.usage = """buildman -b <branch> [options]
>
> diff --git a/tools/buildman/control.py b/tools/buildman/control.py
> index 8e6a08f..d2f4102 100644
> --- a/tools/buildman/control.py
> +++ b/tools/buildman/control.py
> @@ -145,7 +145,7 @@ def DoBuildman(options, args):
>          options.step = len(series.commits) - 1
>
>      # Create a new builder with the selected options
> -    output_dir = os.path.join('..', options.branch)
> +    output_dir = os.path.join(options.output_dir, options.branch)
>      builder = Builder(toolchains, output_dir, options.git_dir,
>              options.threads, options.jobs, checkout=True,
>              show_unknown=options.show_unknown, step=options.step)
> --
> 1.8.3.2
>
>
Regards,
Simon