[U-Boot] [PATCH] mmc: Handle switch error status bit in MMC card status

[Gabbasov, Andrew]

Hi Pantelis,
________________________________________
> From: Gabbasov, Andrew
> Sent: Thursday, April 03, 2014 13:32
> To: Pantelis Antoniou
> Cc: u-boot at lists.denx.de
> Subject: RE: [U-Boot] [PATCH] mmc: Handle switch error status bit in MMC card status
> 
> Hi Pantelis,
> 
> > From: Pantelis Antoniou [panto at antoniou-consulting.com]
> > Sent: Wednesday, April 02, 2014 14:14
> > To: Gabbasov, Andrew
> > Cc: u-boot at lists.denx.de
> > Subject: Re: [U-Boot] [PATCH] mmc: Handle switch error status bit in MMC card status
> >
> > Hi Andrew,
> >
> > In general looks good; only a small nag.
> >
> > On Mar 24, 2014, at 9:39 AM, Andrew Gabbasov wrote:
> >
> > > MMC switch command for unsupported feature (e.g. bus width) sets a switch
> > > error bit in card status. This bit should be checked, and, if it's set,
> > > no access with new controller settings should be performed.
> > >
> [ skipped ]
> > > @@ -505,7 +507,7 @@ static int mmc_change_freq(struct mmc *mmc)
> > >       err = mmc_switch(mmc, EXT_CSD_CMD_SET_NORMAL, EXT_CSD_HS_TIMING, 1);
> > >
> > >       if (err)
> > > -             return err;
> > > +             return ((err == SWITCH_ERR) ? 0 : err);
> > >
> >
> > Change to:
> >
> >         return err == SWITCH_ERR ? 0 : err;
> >
> > No need for parentheses.
> 
> Thank you for the review.
> I'm sending a v2 patch with his change and also re-based to current master head.

Did you have a chance to look at the v2 patch (sent separately)?
WIll you Ack it?

Thanks!

Best regards,
Andrew