[U-Boot] [PATCH v3 7/9] arc: add AXS101 board support

[Wolfgang Denk]

Dear Alexey,

In message <1391445368-10545-8-git-send-email-abrodkin at synopsys.com> you wrote:
> AXS101 is a new generation of devlopment boards from Synopsys that houses
> ASIC with ARC700 and lots of DesignWare peripherals:
...
> +#define CONFIG_SYS_MEMTEST_START	(CONFIG_SYS_SDRAM_BASE + 0x200)
> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_SDRAM_BASE + 0x1234)
...
> +#define CONFIG_BAUDRATE			115200
> +#define CONFIG_SYS_BAUDRATE_TABLE	{9600, 19200, 38400, 57600, 115200}

See before.

> +/*
> + * I2C configuration
> + */
> +#define CONFIG_HARD_I2C			1
> +#define CONFIG_DW_I2C			1
...
> +#define CONFIG_I2C_MULTI_BUS		1
...

Please do not define values for logical variables [please check
everywhere].

> +#define CONFIG_SYS_MAXARGS	16

You define this pretty much inconsistentlyu across your boards.  Is
this intentionally?

> +/*
> + * Environment settings
> + */
> +#define CONFIG_ENV_IS_IN_EEPROM
> +#define CONFIG_ENV_SIZE			0x00200		/* 512 bytes */
> +#define CONFIG_ENV_OFFSET		0

Uh, oh.  Environment in EEPROM is about the worst thing you can do.
You should reconsider this design decision.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The years of peak mental activity are undoubtedly between the ages of
four and eighteen. At four we know all the questions, at eighteen all
the answers.