[U-Boot] [PATCH v3 7/9] arc: add AXS101 board support

[Alexey Brodkin]

Hello Wolfgang,

On Mon, 2014-02-03 at 20:19 +0100, Wolfgang Denk wrote:
> > +/*
> > + * I2C configuration
> > + */
> > +#define CONFIG_HARD_I2C			1
> > +#define CONFIG_DW_I2C			1
> ...
> > +#define CONFIG_I2C_MULTI_BUS		1
> ...
> 
> Please do not define values for logical variables [please check
> everywhere].

Oops, those slipped from my attention.
Thanks for pointing out.

> > +#define CONFIG_SYS_MAXARGS	16
> 
> You define this pretty much inconsistentlyu across your boards.  Is
> this intentionally?

Not clear what do you mean.
All 3 boards have CONFIG_SYS_MAXARGS = 16.

> > +/*
> > + * Environment settings
> > + */
> > +#define CONFIG_ENV_IS_IN_EEPROM
> > +#define CONFIG_ENV_SIZE			0x00200		/* 512 bytes */
> > +#define CONFIG_ENV_OFFSET		0
> 
> Uh, oh.  Environment in EEPROM is about the worst thing you can do.
> You should reconsider this design decision.

Well I may agree on this point.
But due to the fact that Linux driver is still not ready for our custom
NAND controller we don't rely on NAND for whatever storage. And then the
only persistent storage that remains is I2C EEPROM.

Regards,
Alexey