[U-Boot] [PATCH 1/2] power: add PFUZE100 PMIC driver

[Stefano Babic]

Hi Tim,

On 03/02/2014 20:30, Tim Harvey wrote:
>> This is always printed, not only on your board - even from other board,
>> if any, that will use this pmic. If you want that your board always
>> prints the pmic revision, move this output to your board file - maybe in
>> checkboard().
> 
> I noticed that all the pmic drivers in drivers/power/pmic print
> something very generic in their pmic_init such as 'Board PMIC init'
> (even though no initialization or communication with the pmic has
> occurred).  I thought I would be a bit more specific and display
> exactly which PMIC init has been called and provide some details about
> the PMIC version.
> 
> I would agree that this can go into checkboard()
> 
> Is there value in adding the 'puts("Board PMIC init\n")? 

I do not think so

> I didn't
> want to display that if the pmic isn't present (as this PMIC isn't
> present on some Ventana boards).

Agree.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================