[U-Boot] [PATCH v4] socfpga: Add socfpga preloader signing to mkimage

[Wolfgang Denk]

Dear Charles,

In message <CAE21AQp2GSPedrDakio1wPa3vGTwjd-3D1wSQM0WhG9r-8Bzcg at mail.gmail.com> you wrote:
> 
> > > I asked before: Can we not use "ALL-$(CONFIG_SOCFPGA)" and avoid the
> > > ifdef ?
...
> I can certainly avoid the ifdef, but there is already another one three
> lines down
> for the SAMSUNG case:
> 
>  ifdef CONFIG_SOCFPGA
> ALL-y += $(OBJTREE)/socfpga-signed-preloader.bin
> endif
> 
> ifdef CONFIG_SAMSUNG
> ALL-y    += $(obj)/$(BOARD)-spl.bin
> endif
> 
> It seems odd to me that you would want different conventions in the same
> Makefile,
> but if that is what you want then that is what you will get.

Existing poor code should not be used as reference for adding new bad
code.  If possible, it should be imprived -patches are welcome.  In any
case, please avoid the issues in new code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Hacking's just another word for nothing left to kludge.