[U-Boot] [PATCH v4] socfpga: Add socfpga preloader signing to mkimage

[Charles Manning]

> > I can certainly avoid the ifdef, but there is already another one three
> > lines down
> > for the SAMSUNG case:
> >
> >  ifdef CONFIG_SOCFPGA
> > ALL-y += $(OBJTREE)/socfpga-signed-preloader.bin
> > endif
> >
> > ifdef CONFIG_SAMSUNG
> > ALL-y    += $(obj)/$(BOARD)-spl.bin
> > endif
> >
> > It seems odd to me that you would want different conventions in the same
> > Makefile,
> > but if that is what you want then that is what you will get.
>
> Existing poor code should not be used as reference for adding new bad
> code.  If possible, it should be imprived -patches are welcome.  In any
> case, please avoid the issues in new code.

Thank you for that, though it is not obvious which is poor code and which is 
good code and sometimes one must follow what exists for guidance.

I have cleared this up in the latest version that I posted.

-- Charles