[U-Boot] [PATCH] powerpc:Rename CONFIG_PBLRCW_CONFIG & CONFIG_SYS_FSL_PBL_PBI

Prabhakar Kushwaha prabhakar at freescale.com
Mon Jan 13 06:43:17 CET 2014


Thanks Wolfgang for reviewing this patch.
Please find my reply in-lined


On 1/13/2014 11:02 AM, Wolfgang Denk wrote:
> Dear Prabhakar Kushwaha,
>
> In message <1389587917-10324-1-git-send-email-prabhakar at freescale.com> you wrote:
>> Rename CONFIG_PBLRCW_CONFIG and CONFIG_PBLRCW_CONFIG.
> What is the reason for the reenaming?  Especially, why changing from
> CONFIG_ to CONFIG_SYS_ ?

CONFIG_PBLRCW_CONFIG has 2 CONFIG. it is slightly confusing.

Reason for moving CONFIG_ to CONFIG_SYS:  These defines enables of 
adding RCW(power on reset configuration) and
PBI(pre boot loader commands) in u-boot image. These information will be 
used by SoC hardware for NAND, SD, SPI boot.
As these configuration will be used by SoC hardware. I thought of adding 
CONFIG_SYS.

Please let me know, if I need to rename it again.

>> Also add their details in README.
> ...
>
>> +		CONFIG_SYS_FSL_PBL_PBI
>> +		CONFIG_SYS_FSL_PBL_RCW
>> +		Provides a tool to build boot Image for PBL(Pre boot loader)
>> +		Here PBL can be used to load some instructions and/or data for
>> +		pre-initialization.
>> +		Define both configs to enable above feature.
> Hm...This does not really explain what CONFIG_SYS_FSL_PBL_PBI or
> CONFIG_SYS_FSL_PBL_RCW actually means.
>
>
You are right. Let me correct it.

Thanks,
Prabhakar






More information about the U-Boot mailing list