[U-Boot] [PATCH 1/3] config: Update envs for trats and trats2 - new entries for new partitions

Lukasz Majewski l.majewski at majess.pl
Wed Jan 15 21:32:37 CET 2014


Hi Gerard,

> On Tue, Jan 14, 2014 at 08:02 +0100, Lukasz Majewski wrote:
> > 
> > diff --git a/include/configs/trats.h b/include/configs/trats.h
> > index 6cd15c2..0bdfe86 100644
> > --- a/include/configs/trats.h
> > +++ b/include/configs/trats.h
> > @@ -143,7 +143,10 @@
> >  	"u-boot mmc 80 400;" \
> >  	"uImage ext4 0 2;" \
> >  	"exynos4210-trats.dtb ext4 0 2;" \
> > -	""PARTS_ROOT" part 0 5\0"
> > +	""PARTS_BOOT" part 0 2;" \
> > +	""PARTS_ROOT" part 0 5;" \
> > +	""PARTS_DATA" part 0 6;" \
> > +	""PARTS_UMS" part 0 7\0"
> 
> Have recent compilers become stricter about string concatenation?

I'm using ELDK 5.3 toolchain and this code compiles without warnings.
Also I've tested it with Pengutronix's OSELAS 4.8.2 (OSEALS 2013.12).

> ISTR that a space is recommended (which helps human readers as
> well).

Could you be more specific about the missing space?

Also, since we close the release in a few days, I'd like to ask for
pulling this code as it is.

Those are envs related to DFU/THOR, so probably will be changed in a
near future.

> 
> 
> virtually yours
> Gerhard Sittig

Best regards,
Lukasz Majewski
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140115/e224379b/attachment.pgp>


More information about the U-Boot mailing list