[U-Boot] [PATCH 1/3] config: Update envs for trats and trats2 - new entries for new partitions

[Gerhard Sittig]

On Wed, Jan 15, 2014 at 21:32 +0100, Lukasz Majewski wrote:
> 
> Hi Gerard,
> 
> > On Tue, Jan 14, 2014 at 08:02 +0100, Lukasz Majewski wrote:
> > > 
> > > diff --git a/include/configs/trats.h b/include/configs/trats.h
> > > index 6cd15c2..0bdfe86 100644
> > > --- a/include/configs/trats.h
> > > +++ b/include/configs/trats.h
> > > @@ -143,7 +143,10 @@
> > >  	"u-boot mmc 80 400;" \
> > >  	"uImage ext4 0 2;" \
> > >  	"exynos4210-trats.dtb ext4 0 2;" \
> > > -	""PARTS_ROOT" part 0 5\0"
> > > +	""PARTS_BOOT" part 0 2;" \
> > > +	""PARTS_ROOT" part 0 5;" \
> > > +	""PARTS_DATA" part 0 6;" \
> > > +	""PARTS_UMS" part 0 7\0"
> > 
> > Have recent compilers become stricter about string concatenation?
> 
> I'm using ELDK 5.3 toolchain and this code compiles without warnings.
> Also I've tested it with Pengutronix's OSELAS 4.8.2 (OSEALS 2013.12).

With "recent" I meant "so recent that they are not yet in
widespread use".  Can't even remember whether it was a specific
version of a compiler, or a pending C language standard that was
said to become stricter, my memory is failing on me.  Is there
someone around with better memorization capabilities? :)

> > ISTR that a space is recommended (which helps human readers as
> > well).
> 
> Could you be more specific about the missing space?

What I meant is quite simple.  Put whitespace between the strings
that you want to have concatenated.  Instead of

  ""PARTS_BOOT" part 0 5\0"

write something "more portable" (and more readable?) like

  "" PARTS_BOOT " part 0 5\0"

which should not be too much of an issue.  It's not that the
semantics of string concatenation would change, it's just that
syntax is expected to become stricter, and code should not
(ab)use the gray areas that one currently may get away with.

> Also, since we close the release in a few days, I'd like to ask for
> pulling this code as it is.

No problem there, I was just trying to raise or keep awareness.
Just queue another editor session and follow up with a cleanup
later.  Even better if you will touch the code anyway.


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de