[U-Boot] [PATCH 3/3] sf: Use shortcut names
Detlev Zundel
dzu at denx.de
Mon Jan 20 12:05:12 CET 2014
Hi Jagan and Marek,
> On Friday, January 17, 2014 at 03:41:47 PM, Jagannadha Sutradharudu
> Teki wrote:
>> - SPI_FLASH -> SF
>> - ARRAY_SLOW -> AS
>> - ARRAY_FAST -> AF
>> - DUAL_OUTPUT_FAST -> DOF
>> - DUAL_IO_FAST - DIOF
>> - QUAD_OUTPUT_FAST - QOF
>> - QUAD_IO_FAST - QIOF
>
> Now this really makes the code impossible to understand :-(
I totally agree with Marek that this is the wrong way to go. Doing a
change like this is a change to the worse as it removes understandable
constants and replaces them with adhoc abbreviations.
Please don't do that.
Thanks
Detlev
--
Men are born ignorant, not stupid; they are made stupid by education.
--Bertrand Russell
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
More information about the U-Boot
mailing list