[U-Boot] [PATCH 3/3] sf: Use shortcut names

Jagan Teki jagannadh.teki at gmail.com
Mon Jan 20 12:41:41 CET 2014


On Mon, Jan 20, 2014 at 4:35 PM, Detlev Zundel <dzu at denx.de> wrote:
> Hi Jagan and Marek,
>
>> On Friday, January 17, 2014 at 03:41:47 PM, Jagannadha Sutradharudu
>> Teki wrote:
>>> - SPI_FLASH -> SF
>>> - ARRAY_SLOW -> AS
>>> - ARRAY_FAST -> AF
>>> - DUAL_OUTPUT_FAST -> DOF
>>> - DUAL_IO_FAST - DIOF
>>> - QUAD_OUTPUT_FAST - QOF
>>> - QUAD_IO_FAST - QIOF
>>
>> Now this really makes the code impossible to understand :-(
>
> I totally agree with Marek that this is the wrong way to go.  Doing a
> change like this is a change to the worse as it removes understandable
> constants and replaces them with adhoc abbreviations.
>
> Please don't do that.

Just ignore this these were updated in
[PATCH 4/6] sf: Update read/write command macros

-- 
Thanks,
Jagan.


More information about the U-Boot mailing list