[U-Boot] [PATCH] Powerpc/QE: Add QE support for T1040

Timur Tabi timur at tabi.org
Sat Jan 25 16:49:28 CET 2014


On Fri, Jan 24, 2014 at 3:05 AM, Zhao Qiang <B45475 at freescale.com> wrote:
> +#ifdef CONFIG_PPC_T1040
> +       qe_upload_firmware((const void *)CONFIG_SYS_QE_UCODE_FW_ADDR);
> +#else
>         qe_upload_firmware((const void *)CONFIG_SYS_QE_FMAN_FW_ADDR);
> +#endif
>


It's been a while since I looked at the QE code in U-Boot, but this
should be unnecessary.  CONFIG_SYS_QE_FMAN_FW_ADDR is supposed to
point to the QE microcode blob.  Why do you need to define
CONFIG_SYS_QE_UCODE_FW_ADDR?  That's redundant.


More information about the U-Boot mailing list