[U-Boot] [PATCH] Powerpc/QE: Add QE support for T1040

[qiang.zhao at freescale.com]

On Sat, Jan 25, 2014 at 11:49 PM, Timur Tabi<timur at tabi.org> wrote:
> -----Original Message-----
> From: Timur Tabi [mailto:timur at tabi.org]
> Sent: Saturday, January 25, 2014 11:49 PM
> To: Zhao Qiang-B45475
> Cc: U-Boot Mailing List; Xu Jiucheng-B37781; Xie Xiaobo-R63061
> Subject: Re: [U-Boot] [PATCH] Powerpc/QE: Add QE support for T1040
> 
> On Fri, Jan 24, 2014 at 3:05 AM, Zhao Qiang <B45475 at freescale.com> wrote:
> > +#ifdef CONFIG_PPC_T1040
> > +       qe_upload_firmware((const void *)CONFIG_SYS_QE_UCODE_FW_ADDR);
> > +#else
> >         qe_upload_firmware((const void *)CONFIG_SYS_QE_FMAN_FW_ADDR);
> > +#endif
> >
> 
> 
> It's been a while since I looked at the QE code in U-Boot, but this
> should be unnecessary.  CONFIG_SYS_QE_FMAN_FW_ADDR is supposed to point
> to the QE microcode blob.  Why do you need to define
> CONFIG_SYS_QE_UCODE_FW_ADDR?  That's redundant.
> 
CONFIG_SYS_QE_FMAN_FW_ADDR is used for Fman microcode while CONFIG_SYS_QE_UCODE_FW_ADDR used 
For QE microcode.

Regards,
Zhao Qiang