[U-Boot] [PATCH] ARM: bcm2835: config.mk isn't needed

[Andreas Färber]

Hi,

Am 29.01.2014 06:42, schrieb Stephen Warren:
> The entries in config.mk were needed so that U-Boot could be built
> with an old version of the Raspberry Pi Foundation's toolchain. Without
> them, the build would error out with:
> 
> ...-ld: error: .../libgcc.a(_bswapsi2.o) uses VFP register arguments,
> u-boot does not
> 
> However, none of the 3 toolchains in the latest version of their
> tools.git, nor the Ubuntu/Linaro ARM compilers in at least Ubuntu Quantal
> or Saucy, need these options set in order to compile a working U-Boot.
> Hence, remove the options for simplicity.
> 
> Reported-by: Tom Rini <trini at ti.com>
> Signed-off-by: Stephen Warren <swarren at wwwdotorg.org>
> ---
>  arch/arm/cpu/arm1176/bcm2835/config.mk | 19 -------------------
>  1 file changed, 19 deletions(-)
>  delete mode 100644 arch/arm/cpu/arm1176/bcm2835/config.mk

No objection against the patch, but why was arch/arm/config.mk using
-msoft-float in the first place? It's been changed from hardcoded to
$(call cc-option ...)-wrapped [1], which may explain your experimental
results, but IIUC it will still prefer -msoft-float if the compiler
supports it [2] rather than if the SoC needs it, right? tegra20 for
instance does support the hard-float ABI, too.

Regards,
Andreas

[1]
http://git.denx.de/?p=u-boot.git;a=commit;h=0ae7653128c80a4f2920cbe9b124792c2fd9d9e0
[2]
http://git.denx.de/?p=u-boot.git;a=blob;f=config.mk;h=b824bb3469dd577909ad804d655f29d56f0b14cd;hb=HEAD#l103

> diff --git a/arch/arm/cpu/arm1176/bcm2835/config.mk b/arch/arm/cpu/arm1176/bcm2835/config.mk
> deleted file mode 100644
> index b87ce24..0000000
> --- a/arch/arm/cpu/arm1176/bcm2835/config.mk
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -#
> -# (C) Copyright 2012 Stephen Warren
> -#
> -# See file CREDITS for list of people who contributed to this
> -# project.
> -#
> -# This program is free software; you can redistribute it and/or
> -# modify it under the terms of the GNU General Public License
> -# version 2 as published by the Free Software Foundation.
> -#
> -# This program is distributed in the hope that it will be useful, but
> -# WITHOUT ANY WARRANTY; without even the implied warranty of
> -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> -# GNU General Public License for more details.
> -
> -# Don't attempt to override the target CPU/ABI options;
> -# the Raspberry Pi toolchain does the right thing by default.
> -PLATFORM_RELFLAGS := $(filter-out -msoft-float,$(PLATFORM_RELFLAGS))
> -PLATFORM_CPPFLAGS := $(filter-out -march=armv5t,$(PLATFORM_CPPFLAGS))

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg