[U-Boot] [PATCH] ARM: bcm2835: config.mk isn't needed

[Tom Rini]

On Wed, Jan 29, 2014 at 10:22:18AM +0100, Andreas Färber wrote:
> Hi,
> 
> Am 29.01.2014 06:42, schrieb Stephen Warren:
> > The entries in config.mk were needed so that U-Boot could be built
> > with an old version of the Raspberry Pi Foundation's toolchain. Without
> > them, the build would error out with:
> > 
> > ...-ld: error: .../libgcc.a(_bswapsi2.o) uses VFP register arguments,
> > u-boot does not
> > 
> > However, none of the 3 toolchains in the latest version of their
> > tools.git, nor the Ubuntu/Linaro ARM compilers in at least Ubuntu Quantal
> > or Saucy, need these options set in order to compile a working U-Boot.
> > Hence, remove the options for simplicity.
> > 
> > Reported-by: Tom Rini <trini at ti.com>
> > Signed-off-by: Stephen Warren <swarren at wwwdotorg.org>
> > ---
> >  arch/arm/cpu/arm1176/bcm2835/config.mk | 19 -------------------
> >  1 file changed, 19 deletions(-)
> >  delete mode 100644 arch/arm/cpu/arm1176/bcm2835/config.mk
> 
> No objection against the patch, but why was arch/arm/config.mk using
> -msoft-float in the first place? It's been changed from hardcoded to
> $(call cc-option ...)-wrapped [1], which may explain your experimental
> results, but IIUC it will still prefer -msoft-float if the compiler
> supports it [2] rather than if the SoC needs it, right? tegra20 for
> instance does support the hard-float ABI, too.

U-Boot for ARM _is_ soft-float.  There's some issue with an older RPi
foundation toolchain that causes what at first glance looks like an odd
choice of VFP using function to be used when it doesn't need to be.
That's not to say we cannot compile with an armhf-only toolchain.  We
can and I do daily.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140129/0418092d/attachment.pgp>