[U-Boot] [RFC] [PATCH] omap3_beagle: fdt: xMA/B set hsusb2_power_reg active-high

[Robert Nelson]

On Tue, Jan 28, 2014 at 5:31 PM, Robert Nelson <robertcnelson at gmail.com> wrote:
> With the xM revision C, the DC control of the usb hub was inverted.
>
> By adding the enable-active-high property to hsusb2_power_reg, mainline omap3-beagle-xm.dtb
> will now activiate properly activate the usb hub on older xMA/B varients.
>
> Signed-off-by: Robert Nelson <robertcnelson at gmail.com>
> CC: Tom Rini <trini at ti.com>
> ---
>  include/configs/omap3_beagle.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/configs/omap3_beagle.h b/include/configs/omap3_beagle.h
> index c58bc91..d7d63ce 100644
> --- a/include/configs/omap3_beagle.h
> +++ b/include/configs/omap3_beagle.h
> @@ -249,6 +249,9 @@
>                         "setenv fdtfile omap3-beagle-xm.dtb; fi; " \
>                 "if test $fdtfile = undefined; then " \
>                         "echo WARNING: Could not determine device tree to use; fi; \0" \
> +       "fixfdt=" \
> +               "if test $beaglerev = xMAB; then " \
> +                       "fdt addr ${fdtaddr}; fdt resize; fdt set /hsusb2_power_reg enable-active-high; fi; \0" \
>         "bootenv=uEnv.txt\0" \
>         "loadbootenv=fatload mmc ${mmcdev} ${loadaddr} ${bootenv}\0" \
>         "importbootenv=echo Importing environment from mmc ...; " \
> @@ -308,6 +311,7 @@
>         "setenv bootfile zImage;" \
>         "if run loadimage; then " \
>                 "run loadfdt;" \
> +               "run fixfdt;" \
>                 "run mmcbootz; " \
>         "fi; " \
>
> --
> 1.8.5.3

I've listed this as an RFC, as i'm not sure if there is a generic way
we should be doing device tree fixup's in u-boot.

I have thought about splitting omap3-beagle-xm.dtb into two variants
"ab" and "c" with just a simple one line delta:

https://github.com/RobertCNelson/armv7-multiplatform/blob/v3.13.x/patches/omap3_beagle_xm_rework/0002-ARM-dts-omap3-beagle-xm-ab-usb-host-is-active-high-t.patch

But it's just so trivial to just fix it in u-boot instead.

Thoughts?

Regards,

-- 
Robert Nelson
http://www.rcn-ee.com/