[U-Boot] [PATCH 6/6] board: bcm28155_ap: Add board files

[Tom Rini]

On Mon, Jan 27, 2014 at 10:53:30AM -0800, Darwin Rambo wrote:

> Add support for the bcm28155_ap reference board.
> 
> Signed-off-by: Darwin Rambo <drambo at broadcom.com>
> Reviewed-by: Steve Rae <srae at broadcom.com>
> Reviewed-by: Tim Kryger <tkryger at linaro.org>
[snip]
> +	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;

Please use get_ram_size(...);

> +/* Memory testing range */
> +#define CONFIG_SYS_MEMTEST_START	CONFIG_SYS_SDRAM_BASE
> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + SZ_1M)

Please see doc/README.memory-test

> +#define CONFIG_SYS_BAUDRATE_TABLE	{9600, 19200, 38400, 57600, \
> +					115200, 230400, 460800, 921600}

Unless you really use those higher values in U-Boot, please use the
default table.

> +#define CONFIG_SYS_PROMPT_HUSH_PS2	"> "

Unneeded now.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140129/2daa7a51/attachment.pgp>