[U-Boot] [PATCH 6/6] board: bcm28155_ap: Add board files

[Darwin Rambo]

On 14-01-29 02:33 PM, Tom Rini wrote:
> On Mon, Jan 27, 2014 at 10:53:30AM -0800, Darwin Rambo wrote:
> 
>> Add support for the bcm28155_ap reference board.
>>
>> Signed-off-by: Darwin Rambo <drambo at broadcom.com>
>> Reviewed-by: Steve Rae <srae at broadcom.com>
>> Reviewed-by: Tim Kryger <tkryger at linaro.org>
> [snip]
>> +	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
> 
> Please use get_ram_size(...);
We tried using this on our reference board and it hangs accessing memory
regions that are not populated. Our memory controller doesn't appear to
properly support accessing regions that are not backed by physical
sdram. So I think it's best to keep this code as is and consider this
approach for future designs.

> 
>> +/* Memory testing range */
>> +#define CONFIG_SYS_MEMTEST_START	CONFIG_SYS_SDRAM_BASE
>> +#define CONFIG_SYS_MEMTEST_END		(CONFIG_SYS_MEMTEST_START + SZ_1M)
> 
> Please see doc/README.memory-test
OK. I think I'll disable CONFIG_CMD_MEMORY and remove this stuff.
> 
>> +#define CONFIG_SYS_BAUDRATE_TABLE	{9600, 19200, 38400, 57600, \
>> +					115200, 230400, 460800, 921600}
> 
> Unless you really use those higher values in U-Boot, please use the
> default table.
OK
> 
>> +#define CONFIG_SYS_PROMPT_HUSH_PS2	"> "
> 
> Unneeded now.
OK
>